Handling drupal-scaffold and drupal/core-recommended #28

grasmash / composerize-drupal

Convert a non-Composer-managed Drupal application (e.g., one created via tarball) to a Composer-managed Drupal application.

MIT License

125 stars 20 forks source link

Handling drupal-scaffold and drupal/core-recommended #28 #29

Closed mohammadzo closed 3 years ago

mohammadzo commented 3 years ago

@grasmash Any thought or suggestion for this pr?

grasmash commented 3 years ago

Hm, I'm not sure why tests didn't run against this PR? We need to see if they pass.

grasmash commented 3 years ago

Actually tests did run they just didn't get posted here. See: https://travis-ci.org/github/grasmash/composerize-drupal/builds/719718252

mohammadzo commented 3 years ago

@grasmash I want to remove the following from the template, since they do not work with composer 2.0. Any objection?

    "grasmash/drupal-security-warning": "^1.0.0",
    "oomphinc/composer-installers-extender": "^1.1",
    "wikimedia/composer-merge-plugin": "^1.4.1"

grasmash commented 3 years ago

That's fine!

mohammadzo commented 3 years ago

I believe unit test passed. This is ready to review.

grasmash commented 3 years ago

The latest tests have failed: https://travis-ci.org/github/grasmash/composerize-drupal/builds/743279292

coveralls commented 3 years ago

Coverage increased (+0.07%) to 93.962% when pulling 01286bd035e8555301b838474cce8a6c90754670 on mohammadzo:support-drupal8.8 into a995ab9dc603fdfbbab4d668e6b9ab387470c542 on grasmash:master.