grasmash / composerize-drupal

Convert a non-Composer-managed Drupal application (e.g., one created via tarball) to a Composer-managed Drupal application.
MIT License
125 stars 20 forks source link

Add composer2 compatibility #30

Closed highermath closed 3 years ago

highermath commented 3 years ago

composerize-drupal will not install with composer 2. Works fine with composer 1.

plousia commented 3 years ago

Seconding this. I've had to downgrade back to Composer 1 to use composerize-drupal again.

BrianGilbert commented 3 years ago

another vote for Composer 2 support now that version 1 is deprecated

SebastienGicquel commented 3 years ago

I would also like to have support for Composer 2.

fkelly12054 commented 3 years ago

Another vote to get this committed. Trying to set up Composer on shared hosting. Have Composer 2 running well. No one is going to go back to Composer 1 given the tremendous improvements in Composer 2 but sites built from the tar.gz's need to be Composerized somehow. It's a shame these fixes are just sitting without being committed.

phenaproxima commented 3 years ago

The problem is, the pull request's tests are not passing. It's not clear why; I haven't had a lot of time available to debug this. But I'm not comfortable merging it if it's going to make the tests fail, since that could mean other things are broken.

If anyone would like to take a crack at a new pull request to make this change with passing tests, that would be very welcome!

fkelly12054 commented 3 years ago

Thank you for the quick response. I'm looking at: https://www.drupal.org/docs/installing-drupal/add-composer-to-an-existing-site and just may have to do this "manually". I'm not at an appropriate expertise level to make changes to have this pass the tests. Doing it "manually" is probably a good learning exercise, but a lot of mucking around with getting the exact list of contrib modules that need to be included.

grasmash commented 3 years ago

Resolved!