graspee / polutils

Automatically exported from code.google.com/p/polutils
Apache License 2.0
0 stars 0 forks source link

Item Data General not loading #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I'm not getting anything when trying to load general items.

Original issue reported on code.google.com by scr...@gmail.com on 4 Nov 2013 at 9:43

GoogleCodeExporter commented 9 years ago
Actually I'm not getting data from usable or general items in all langs.

Original comment by scr...@gmail.com on 4 Nov 2013 at 9:46

GoogleCodeExporter commented 9 years ago
Normal items have had a change to their dat file. There is a new uint32 just 
before the string tables for each item.

I uploaded a fixed POLUtils here:
http://www.ffevo.net/topic/3277-polutils-updated-for-oct-2013/

Since POLUtils uses a horrid syntax style for coding I can't submit a patch 
since my version unbranches the indentation the project uses.

Here is what is changed though to make it work:
PlayOnline.FFXI\IThings\Item.cs

Find:
else if (T == Type.Item)

Inside this check, you need to add at the end of the switch:
this.Unknown3_ = BR.ReadUInt32();

Find:
else if (T == Type.UsableItem)

At the end add:
this.Unknown3_ = BR.ReadUInt32();

Original comment by chuck.m....@gmail.com on 17 Nov 2013 at 2:05

GoogleCodeExporter commented 9 years ago
Style is a personal preference - I find Visual Studio's standard settings 
horrid :-)
The tab size of 8 does cause things to look ugly when using standard VS setting 
(tab size 4?). Perhaps for the purpose of patch creation, I should untabify all 
sources.

Anyhoo, for the Item change, Unknown3 is already in use for some item types, so 
I'll use Unknown1 (although that goes against my strict numbering, it's easier 
than adding an extra Unknown4).

Fix committed in r812 (also includes tab removal for Item.cs; I may apply that 
everywhere if the mood takes me).

Original comment by tim.vanholder@gmail.com on 19 Nov 2013 at 7:17