Closed GoogleCodeExporter closed 9 years ago
GoogleCodeExporter
commented
9 years ago Also, newest XML pulled from the patched version of POLUtils available here:
https://docs.google.com/leaf?id=0Bwe5vzKELCsPZDUxNzBjYTMtZTAyNy00ODZjLTliZjUtYjl
hMGRjZDIzNThj&sort=name&layout=list&num=50Original comment by doomer18 on 24 Sep 2010 at 12:13
GoogleCodeExporter
commented
9 years ago Will look at it over the weekend.
Am I right in seeing this as the new layout for the existing spell/ability
files (there's no change to the rom file mappings xml for the data browser)? If
so, I'm not sure if POLUtils needs to retain support for the old layout (unless
files in the old format remain present in the tree).
As an aside: Do try to use the same editor settings as were used to create the
code (indent=2, tab=8); looking at the patch it looks like some of the changes
are not consistent with the formatting of the surrounding code.
Original comment by tim.vanholder@gmail.com on 24 Sep 2010 at 12:15
GoogleCodeExporter
commented
9 years ago This is in fact the new layout for a new file 118/114.DAT. The patch should've
included a modification to the ROMFileMappings.xml file.
Bah it appears I didn't include the file in the patch ;;
Updating a new one here shortly.
Here...
Original comment by doomer18 on 24 Sep 2010 at 3:16
Attachments:
GoogleCodeExporter
commented
9 years ago [deleted comment][deleted comment][deleted comment]Re: your aside
Honestly i've never messed with the Editor settings, problem is the "indent=2,
tab=8" i haven't changed in VS2010. Also everytime I open one of your files it
asks me to "Tabify" or "Untabify" or ignore...
This is all just copy & paste of your existing code into my editor ^^
I'll see to getting it fixed, now, time for work.
PS--Should I "Keep Tabs" or "Insert Spaces" when I modify the editor settings?
and should Identing be "Block" "Smart" or "None" XD
PPS -- Also, Community is generating me a list of all files with the new
Abyssea quests, etc So I'll be posting an additional ROMMappings.XML patch
specifically to add new Menu items to the DataBrowser.
PPPS -- Scratch that, I guess I'll upload a patch to it later, community hasn't
put together the list yet...Original comment by doomer18 on 25 Sep 2010 at 3:00
GoogleCodeExporter
commented
9 years ago Please add this list of DAT files into the DATA Browser ROMMappings.xml file. I
have included the actual file number as well, but after looking at the
ROMMappings, I can't see how you do all the areas. Might I suggest grouping
the Mob List Areas by something more than region however? ie, possibly by
Expansion they were released in?
Or possibly (Present) (Past) (Abyssea) (Others) as the list has grown EXTREMELY
long and takes up the entire screen on a 1080p monitor ^^
List as follows
Mob List files
Scars of Abyssea
ROM/27/24 Attohwa 6935
RoM/27/25 Misareaux 6936
ROM/27/26 vunkerl 6937
Heroes of Abyssea
ROM/26/119 = Walk of Echoes mob list 6902
ROM/26/69.dat - Aby-La Theine mob list 6852
ROM/25/110.dat - Aby-Tahrongi mob list 6765
ROM/25/80.dat - Aby-Konschtat mob list 6735
-2 folder for dialog tables e.g.
ROM/24/119 = Walk of Echoes Dialog Tables 6602
ROM/24/69.dat - Aby-La Theine Dialog Tables 6552
ROM/23/110.dat - Aby-Tahrongi Dialog Tables 6465
ROM/23/80.dat - Aby-Konschtat Dialog Tables 6435
Scars of Abyssea dialogue files
ROM/25/24 Attohwa 6635
ROM/25/25 Misareaux 6636
ROM/25/26 Vunkerl Inlet 6637
Other stuff:
ROM/27/80.dat = Monster Weaponskill List 7035
ROM/27/76.dat = Client System Messages List 7031
ROM/27/68.dat = element / resist! cover! messages 7023
(incl. Bind Release Probability at bottom lol)
ROM/27/66.dat = magic/combat skill name list 7021
ROM/27/74.dat = Statuses Lists 7029
ROM/27/72.dat = System Messages List 7027
ROM/27/70.dat = Emote Message List 7025
Original comment by doomer18 on 26 Sep 2010 at 8:08
GoogleCodeExporter
commented
9 years ago OK, so:
- There's a new spell/ability file (ROM/118/114.DAT) with a layout as described
in your patch.
- The newer expansions have not added "ROMn" folders (the last to do that being
WotG)
I'll see what I can do for these new entries. Perhaps for larger stuff like
this it could be better to have a discussion on the developer forum first,
because this issue tracker isn't the handiest of things for that.
I think for the areas it assumes "base rom file number + area number".
As for the editor settings, I'll see how easy it is to save my settings in a
file for VS to load (although I'm not sure if VS's settings files are
version-independent).
Original comment by tim.vanholder@gmail.com on 26 Sep 2010 at 11:31
GoogleCodeExporter
commented
9 years ago FileType added (but without the hardcoded magic entry counts and better
validation).
IThings added.
Enums updated.
Next up: data browser. Adding the ROM mapping is easy, but I also want to see
if I can improve the listview to deal with heterogenous lists (like the
spell+ability one) better.
Original comment by tim.vanholder@gmail.com on 26 Sep 2010 at 2:09
GoogleCodeExporter
commented
9 years ago I just added the rom mapping for now - splitting the listview would be too much
work for the time I have.
I also found an additional field at the end of the new ability info - looks
like it's related to dances (it's -1 for non-dance abilities). Could be
duration or casting time or somesuch.
That's about all I have time for today. I'll have a look at the other rom
mappings later. I would need to know all 4 ROMs (en/fr/de/jp) for those though
(although in most cases these can be inferred from the file number sequence for
the english ones).
Original comment by tim.vanholder@gmail.com on 26 Sep 2010 at 3:17
GoogleCodeExporter
commented
9 years ago Reworked the data browser menus a little; hierarchy for area-related stuff
(dialogs, maps, mobs) is now Major-Expansion>Region>Area.
I'm adding the new areas provided above as well - but where is "Walk of
Echoes", i.e. what region does it belong to (there were no new regions added by
the last expansion as far as I can tell)?
Original comment by tim.vanholder@gmail.com on 26 Sep 2010 at 5:23
GoogleCodeExporter
commented
9 years ago Check your email, Unknown in AbilityInfo2 is not unknown, it's actually the
Shared Timer index between job abilities that share timers now (ie
Steal/Despoil, Collaborator/Accomplice.
Also,
Walk of Echoes is part of the Shadowreign zones as far as I can tell.
Wings of the Goddess would be the best explanation.
Also, expansions after Wings of the Goddess (specifically the new ROM# folders)
A Crystalline Prophecy ROM6
A Moogle Kupo d'Etat ROM7
A Shantotto Ascension ROM8
Verified by new textures added into those ROM folders, one is Aldo and a Crystal
another is different textures related to the moogle expansion, and the last is
all the different textures used on the different Shatotto'sOriginal comment by doomer18 on 26 Sep 2010 at 5:29
GoogleCodeExporter
commented
9 years ago Unknown #2 in AbilityInfo2 identified as TP cost (in %) - applies to DNC dances
only.
Since Walk of Echoes connects to Xarcabard, I'll put it under the same region.
Original comment by tim.vanholder@gmail.com on 30 Sep 2010 at 3:45
GoogleCodeExporter
commented
9 years ago Sent you an email regarding the Walk of Echoes to better explain what I was
talking about, hope you get it before you fully commit the Map addition of Walk
of Echoes.Original comment by doomer18 on 30 Sep 2010 at 4:09
GoogleCodeExporter
commented
9 years ago All changes for this have been committed.
Will probably build a release during the weekend unless further issues crop up.
Original comment by tim.vanholder@gmail.com on 30 Sep 2010 at 6:55
GoogleCodeExporter
commented
9 years ago Marking this as fixed. Spell & Ability info now fully supported (including nice
handling in the data browser for the fact that one file contains 2 types of
data).
Release build probably tomorrow.
Original comment by tim.vanholder@gmail.com on 2 Oct 2010 at 5:56
Original issue reported on code.google.com by
doomer18on 23 Sep 2010 at 11:48Attachments: