search

graspit-simulator / graspit

The GraspIt! simulator
http://graspit-simulator.github.io/
Other
176 stars 82 forks source link

Staubli Control #11

Closed jvarley closed 7 years ago

jvarley commented 8 years ago

Staubli Control Code does not exist in graspit, can we remove:

jvarley@captiva:~/graspit_org/graspit$ grep -ir Staubli . ./ui/ui_mainWindow.h: QAction staubliControl; ./ui/ui_mainWindow.h: staubliControl = new QAction(MainWindowUI); ./ui/ui_mainWindow.h: staubliControl->setObjectName(QString::fromUtf8("staubliControl")); ./ui/ui_mainWindow.h: staubliControl->setName("staubliControl"); ./ui/ui_mainWindow.h: Misc->addAction(staubliControl); ./ui/ui_mainWindow.h: staubliControl->setIconText(QApplication::translate("MainWindowUI", "Staubli Control Panel...", 0, QApplication::UnicodeUTF8)); ./ui/ui_mainWindow.h: staubliControl->setText(QApplication::translate("MainWindowUI", "Staubli Control Panel...", 0, QApplication::UnicodeUTF8)); ./ui/mainWindow.cpp:#ifdef STAUBLI_CONTROL_ENABLED ./ui/mainWindow.cpp:#include "staubli/staubliControlDlg.h" ./ui/mainWindow.cpp: QObject::connect(mUI->staubliControl, SIGNAL(triggered()), ./ui/mainWindow.cpp: this, SLOT(misStaubliControlDlg())); ./ui/mainWindow.cpp:void MainWindow::misStaubliControlDlg() ./ui/mainWindow.cpp:#ifdef STAUBLI_CONTROL_ENABLED ./ui/mainWindow.cpp: StaubliControlDlg dlg = new StaubliControlDlg(mWindow); ./ui/mainWindow.ui: ./ui/mainWindow.ui: ./ui/mainWindow.ui: staubliControl ./ui/mainWindow.ui: Staubli Control Panel... ./ui/mainWindow.ui: Staubli Control Panel... ./ui/mainWindow.h: void misStaubliControlDlg(); Binary file ./.git/index matches Binary file ./.obj/mainWindow.o matches Binary file ./.obj/moc_mainWindow.o matches ./graspit-core.pro:#------------------------------------- Staubli Control ---------------- ./graspit-core.pro:staubli{ ./graspit-core.pro: DEFINES += STAUBLI_CONTROL_ENABLED ./graspit-core.pro: SOURCES += Staubli/staubliControlDlg.cpp \ ./graspit-core.pro: HEADERS += Staubli/staubliControlDlg.h \ ./graspit-core.pro: FORMS += Staubli/staubliControlDlg.ui

jvarley commented 8 years ago

@mateiciocarlie I found an older repo which has the arizona and staubli code. https://github.com/CURG/graspit_handop Should I bring these source files into this repo, or should we remove references to them from this repo? Personally I think we should just remove references to them, but I don't care all that much. I just want it to not be broken one way or the other.

mateiciocarlie commented 8 years ago

While it's great to have a nice library of robot controllers in graspIt!, the way it's done here is really not right - it probably should be all plugin based, and core graspit files should not have all these kinds of references. So I agree - until we have time to check this, and re-architect it properly, let's just clean it up...

jvarley commented 7 years ago

done.