search

graspit-simulator / graspit

The GraspIt! simulator
http://graspit-simulator.github.io/
Other
174 stars 82 forks source link

fixed includes in QPSolver code that didn't reflect the changes made in pull request #120 #123

Closed mkghaas closed 7 years ago

jvarley commented 7 years ago

LGTM

jvarley commented 7 years ago

Can we move all of these headers out of 

graspit/src/math/*.h

and into

graspit/include/graspit/math/*.h

In order to be consistent with the rest of GraspIt!. Headers from src are not copied to the install path, so it would not be possible to utilize these headers from a plugin that gets its headers from /usr/local/include/graspit

mkghaas commented 7 years ago

On it. I wasn't sure why the headers were in the source directory to begin with but thought there must be a reason so never changed it

jvarley commented 7 years ago

Yeah, they used to be all over the place.