search

graspit-simulator / graspit

The GraspIt! simulator
http://graspit-simulator.github.io/
Other
180 stars 81 forks source link

Debian Packaging Requirements #132

Closed DavidWatkins closed 6 years ago

DavidWatkins commented 7 years ago

I've added a series of changes that allows graspit to be compiled to a .deb file so it can be uploaded to launchpad for debian downloading. In order to build it you'll need to be on Ubuntu and run bzr -- -uc -us to test this. This is the version that is currently on launchpad.

jvarley commented 7 years ago

Overall looks good.

can you make authors for the man page say columbia university robotics lab and a link to http://graspit-simulator.github.io/

We will also need to change the copyright in the debian: https://github.com/DavidWatkins/graspit/blob/master/debian/copyright

I would put: something like: https://github.com/graspit-simulator/graspit/blob/master/LICENSE.txt#L2

or at least add Andrew Miller and Matei Ciocarlie as they are the original authors.

Excluding the copyright stuff, is there any reason for me not to pull this in at this time. You have tested on 14.04/16.04, with/without ROS?

DavidWatkins commented 7 years ago

I added the changes to the README and copyright. I only tested this on 16.04 with ROS installed. Should I test it without ROS installed? I can add those tests to the travis script if you'd like. Otherwise it should work fine.