Fixed graph matching with similarity matrix of unequal dimensions - Githubissues

graspologic-org / graspologic

Python package for graph statistics

https://graspologic-org.github.io/graspologic/

MIT License

782 stars 142 forks source link

Fixed graph matching with similarity matrix of unequal dimensions #1002

Closed dokato closed 1 year ago

dokato commented 1 year ago

[x] Does this PR have a descriptive title that could go in our release notes?
[x] Does this PR add any new dependencies? No
[x] Does this PR modify any existing APIs? No
- [x] Is the change to the API backwards compatible?
[x] Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Reference Issues/PRs

Fixes #1001.

What does this implement/fix? Briefly explain your changes.

I add padding to the similarity matrix S, so the following _compare_dimensions checks are passing.
Also fixes a small error with auto doc generation from an upstream dependency.

dokato commented 1 year ago

Re: the mypy error I get, is an output type of _adj_pad correct?

Tuple[np.ndarray, np.ndarray, np.ndarray]:

I have impression that it returns a matrix, so np.ndarray.