search

graspologic-org / graspologic

Python package for graph statistics
https://graspologic-org.github.io/graspologic/
MIT License
650 stars 134 forks source link

Ensure we have a non-dev-mode install of graspologic as part of CI/CD workflow #1009

Open bdpedigo opened 1 year ago

bdpedigo commented 1 year ago

Somehow https://github.com/microsoft/graspologic/issues/983 was not caught by our CI/CD workflow

I suspect this is because graspologic is being installed with development dependencies in most (all?) places in our workflow, and typing_extensions was probably being installed as a dependency of a development dependency. I think this is why I also did not notice as I almost always install locally in dev mode.

We should

  1. check if the above is the case and if so,
  2. add a simple step to the workflow that simply installs graspologic in non-dev mode.

If I'm wrong about the above, then I'd still like to figure out how that snuck past us