graspologic-org / graspologic

Python package for graph statistics
https://graspologic-org.github.io/graspologic/
MIT License
650 stars 134 forks source link

Fixed bug in check_dirloop, check_r and check_rel_sbm #1012

Closed GuilhermeMonteiroPeixoto closed 1 month ago

GuilhermeMonteiroPeixoto commented 1 year ago

check_dirloop: You could try replacing the isinstance checks with simple type checks, since bool is a subclass of int and isinstance will also return True if the argument is an int.

check_r: You could try replacing the np.issubdtype check with a simple type check, since float is a subclass of int and np.issubdtype will also return True if the argument is an int.

check_rel_sbm: You could try replacing the nested for loops with a single loop over the flattened array, using the ndarray.flat attribute