hard capped networkx version to avoid incompatability - Githubissues

graspologic-org / graspologic

Python package for graph statistics

https://graspologic-org.github.io/graspologic/

MIT License

650 stars 134 forks source link

hard capped networkx version to avoid incompatability #1016

Closed alyakin314 closed 1 year ago

alyakin314 commented 1 year ago

[x] Does this PR have a descriptive title that could go in our release notes? seems so
[x] Does this PR add any new dependencies? nope
[x] Does this PR modify any existing APIs? nope
- [x] Is the change to the API backwards compatible? irrelevant
[x] Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate? unapplicable?

Reference Issues/PRs

Fixes #1015.

What does this implement/fix? Briefly explain your changes.

Quick-patches the incompatibility by avoiding the netoworkx v.3.0.

Any other comments?

Probably need a better long term fix. Unsure if removing the orderedgraph arguments is sufficient and/or backward compatible.

alyakin314 commented 1 year ago

@bdpedigo sure. only reason i did it this way was because all other packages seemed to have !=. thought there must be special about it.

https://github.com/microsoft/graspologic/blob/349cc77dfa9f06aa41b6837836ce809ee5acbd4c/setup.cfg#L31-L35