search

graspologic-org / graspologic

Python package for graph statistics
https://graspologic-org.github.io/graspologic/
MIT License
650 stars 134 forks source link

Removed references to IDAD in utils.py #1017

Closed hugwuoke closed 1 month ago

hugwuoke commented 1 year ago

Reference Issues/PRs

Fixes #970

hugwuoke commented 1 year ago

@microsoft-github-policy-service agree [company="Johns Hopkins"]

hugwuoke commented 1 year ago

@microsoft-github-policy-service agree

bdpedigo commented 1 year ago

tests are still not passing

hugwuoke commented 1 year ago

I removed the tests, but I did it on dev. When I did the pull request for the deprecation errors, I accidentally pulled the changes to the test as well. I am unsure what to do about it about it applying.

bdpedigo commented 1 year ago

can you just make those changes again on this branch? im not sure what you are asking

hugwuoke commented 1 year ago

I made the changes, and it is the same test that is not passing for both pull requests. I think it is an issue with building documentation because when I run i-sort or black those tests pass but sphinx fails. It says it is an issue with "no python3 in kernal" and it is referencing a jupyter notebook. I couldn't find the juypter notebook in graspologic so I was pretty much lost as to how to trouble shoot from there.

bdpedigo commented 1 year ago

same comment as on the other PR - it looks like you need to rerun code formatting; make sure you are using the most recent version of black to do so (pip install --upgrade black)