graspologic-org / graspologic

Python package for graph statistics
https://graspologic-org.github.io/graspologic/
MIT License
780 stars 142 forks source link

Added option for more efficient graph matching matrix operations #1046

Closed bkj closed 1 year ago

bkj commented 1 year ago

Reference Issues/PRs

N/A

What does this implement/fix? Briefly explain your changes.

Changed internal match/solver.py code to:

Any other comments?

The modified implementation definitely avoids unnecessary computation. Benchmarking this algorithm is hard (very data dependent) so YMMV, but these changes give a 1.5-2x speedup for the settings that I tested.

Additional Information

bdpedigo commented 1 year ago

@bkj just a reminder about the CLA bot, I think everything else is good to go!

bkj commented 1 year ago

How to accept CLA?

https://github.com/microsoft/graspologic/blob/dev/CONTRIBUTING.md says the CLA-bot will comment, but not seeing that

bkj commented 1 year ago

@microsoft-github-policy-service agree