Closed bkj closed 1 year ago
@bkj just a reminder about the CLA bot, I think everything else is good to go!
How to accept CLA?
https://github.com/microsoft/graspologic/blob/dev/CONTRIBUTING.md says the CLA-bot will comment, but not seeing that
@microsoft-github-policy-service agree
Reference Issues/PRs
N/A
What does this implement/fix? Briefly explain your changes.
Changed internal
match/solver.py
code to:trace(X @ Y)
more efficientlyAny other comments?
The modified implementation definitely avoids unnecessary computation. Benchmarking this algorithm is hard (very data dependent) so YMMV, but these changes give a 1.5-2x speedup for the settings that I tested.
Additional Information