[BUG] Scipy deprecations causing importerrors in gensim

graspologic-org / graspologic

Python package for graph statistics

https://graspologic-org.github.io/graspologic/

MIT License

634 stars 134 forks source link

[BUG] Scipy deprecations causing importerrors in gensim #1059

Closed j1c closed 1 month ago

j1c commented 2 months ago

Expected Behavior

scipy function triu used in gensim was deprecated in scipy==1.13.0. Limit scipy version

Example Code

import graspologic

Full Traceback

ImportError: cannot import name 'triu' from 'scipy.linalg'

Your Environment

Python version:
graspologic version:

Additional Details

Any other contextual information you might feel is important.

bdpedigo commented 2 months ago

i noticed https://github.com/piskvorky/gensim/pull/3524 - if they get a fix out soon, would be nice to use that instead of banning future scipy releases

j1c commented 2 months ago

i noticed piskvorky/gensim#3524 - if they get a fix out soon, would be nice to use that instead of banning future scipy releases

Neat. This will probably mean we have to set a minimum to gensim instead then.

bdpedigo commented 2 months ago

agreed. thinking about it more, if you want to ban scipy 1.13 in the meantime like in your PR, i have no problem with that. who knows how long they will take to get a fix out.

bdpedigo commented 1 month ago

covered in https://github.com/graspologic-org/graspologic/pull/1067