search

grasshopper7 / extentreports-cucumber7-adapter

Cucumber-JVM 7 Adapter for Extent Framework
https://ghchirp.online/3196/
MIT License
18 stars 9 forks source link

Could support attach video to spark reports? Many thanks! #24

Open peizijune opened 1 year ago

peizijune commented 1 year ago

someone already raised the point that now video attachment is still not supported by spark reports, but there is nobody raised this enhancement yet

please refer to: http://ghchirp.online/3196/

QQ20230313-160350@2x

many many thanks~

grasshopper7 commented 1 year ago

Yeah I kinda forgot about it. Will have a look. Thanks

grasshopper7 commented 1 year ago

Hi, I have had a look at this but the stumbling block is from the core extentreport code. The spark and html reports do not support any other attachment other than images.

A change will be needed to be made in that code base with a significant update with a PR. That code is not controlled by me.

Other is for me to fork it and put in the required changes. Though currently I am not sure how big the task is.

I will give it a try and lets see if it works.

siva90144 commented 1 year ago

@grasshopper7 any update on this?

grasshopper7 commented 1 year ago

I have added a PR for this. If this is accepted by the owner then videos will be visible in the cucumber spark report also. https://github.com/extent-framework/extentreports-java/pull/400