grassmunk / Chicago95

A rendition of everyone's favorite 1995 Microsoft operating system for Linux.
4.35k stars 150 forks source link

Theme not Applying to GTK-4 applications #256

Open 266-750Balloons opened 1 year ago

266-750Balloons commented 1 year ago

I use XFCE4, but there are two applications I use that transitioned to GTK4 (gHex and gnome-clocks) that have transitioned to GTK 4 and ever since, they have used the Adwaita theme, but with the correct fonts and icons. They used to theme correctly under GTK3. I am assuming this is due to a lack of GTK4 support by Chicago95. Here's an image of the problem: image


Distribution: Debian Bookworm Desktop: XFCE 4.16 Architecture: AMD64 Kernel: 5.18.0-14.2-liquorix-amd64 and several previous normal (non-liquorix) Debian kernels

EMH-Mark-I commented 1 year ago

Currently the Chicago95 GTK theme only supports up to GTK3. I don't think it will work well with GTK4 due to many features being removed.

266-750Balloons commented 1 year ago

image I've decided to go Janeway and try to create a gtk4 theme. Better something than nothing. Here is a screenshot prototype (missing a lot). The only issue so far is I am having trouble changing window button sizes (the gtk3 method doesn't work).

This is my gtk.css so far:

button {
    background-color: #C0C0C0;
    border-style: inset;
    border-width: 1px;
    border-color: white black black white;
    padding: 0;
}
button:active {
    border-color: black;
}
window {
    background-color: #C0C0C0;
    border-style: inset;
    border-width: 1px;
    border-color: white black black white;
color: black;
}
headerbar {
    background-color: #000080;
    padding: 2px;
}

I might make a pull request when I am more ready.

grassmunk commented 1 year ago

I really like it. One of the things I tried to do when I made the theme (and that @EMH-Mark-I continues to do with his GTK edits) is make it look like it would if MS was making it. So If MS made a gtk4 theme in 1995/1998 I think it would look pretty close to this. Well done. I look forward to the pull request.

SelfRef commented 11 months ago

@266-750Balloons How's with the PR? As more and more apps are transitioning to GTK 4 it would be great to have at least a basic support for it.

Nitramakloh commented 11 months ago

image I've decided to go Janeway and try to create a gtk4 theme. Better something than nothing. Here is a screenshot prototype (missing a lot). The only issue so far is I am having trouble changing window button sizes (the gtk3 method doesn't work).

This is my gtk.css so far:

button {
  background-color: #C0C0C0;
  border-style: inset;
  border-width: 1px;
  border-color: white black black white;
  padding: 0;
}
button:active {
  border-color: black;
}
window {
  background-color: #C0C0C0;
  border-style: inset;
  border-width: 1px;
  border-color: white black black white;
color: black;
}
headerbar {
  background-color: #000080;
  padding: 2px;
}

I might make a pull request when I am more ready.

How can I apply that to myself? Simply creating a gtk-4 folder inside the chicago's theme folder?

266-750Balloons commented 10 months ago

Yes, make a gtk-4.0 folder, and then just plop it inside a gtk-3.0.css folder. However, I wouldn't recommend it; it is much more of a proof of concept than anything, and barely usable. At this point, I've had more headway just copying and pasting the gtk-3.0 folder and fixing whatever is broken. I'll see if I can gather that into its own little repo (it's a mess, not yet worthy of a pull request, but mostly usable) later. I need to properly integrate my modifications into the Plus! theme system as well.