Did you read all the READMEs and are system requirements fulfilled?
yes
What did you try to do?
failures on prod related to sms lead us to notice this error in the log:
AttributeError: 'User' object has no attribute 'last_name_name'
What did you expect should have happened?
that typo should have been caught in reivew, of course, but most importantly in tests.
What happened instead?
it went through unnoticed. it failing may even have been unrelated to the sms problem, meaning that it has silently failed since deploy, with unknown side-effects.
WillRuddick
commented
4 years ago
Did you read all the READMEs and are system requirements fulfilled?
yes
What did you try to do?
failures on prod related to sms lead us to notice this error in the log:
What did you expect should have happened?
that typo should have been caught in reivew, of course, but most importantly in tests.
What happened instead?
it went through unnoticed. it failing may even have been unrelated to the sms problem, meaning that it has silently failed since deploy, with unknown side-effects.
What were the exact steps you took?
nothing, just production environment
The typo itself was patched immediately
https://github.com/GrassrootsEconomics/SempoBlockchain/pull/52
but we need to add regression test to make sure this can't happen again.