grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
11 stars 6 forks source link

64 some event page summary stats are incorrect #102

Closed 6mp closed 1 year ago

6mp commented 1 year ago

Addresses #64

Looking at 02/11/2023

image image

Looking at 03/04/2023

image image

A more recent event, 06/10/2023

image image
railway-app[bot] commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ◻️ REMOVED

6mp commented 1 year ago

I forgot to include total participants in the screenshots, I checked all of these dates and it lined up with what is displayed on the portal.

mattsahn commented 1 year ago

I see an issue with the driver count with the new version. When I run your branch, Feb 11 shows 5 drivers, instead of 6. The 5 seems to be based on "confirmed" drivers, but we want to show both confirmed and unconfirmed. We should exclude "Can't Come" drivers, so the number should be 6 i'm pretty sure.

image

Tagging @hgreenhut, too. Henry, you had asked about special groups count. For Feb 11, I see "St. Augustine's" and "Greenacres". The rest are "N/A". So, this count should be "2", not "3". It must be considering "N/A" as the 3rd special group to get that count? image

6mp commented 1 year ago

@mattsahn Ok, I will work on showing both unconfirmed and confirmed drivers.

The way I arrived at the special groups count was by checking in the airtable and just counting the number of special events, even if they don't have anyone coming.

I can exclude the special groups who dont anyone coming if that is what you would like.

mattsahn commented 1 year ago

The way I arrived at the special groups count was by checking in the airtable and just counting the number of special events, even if they don't have anyone coming.

Ok, I see. In that case, fine to leave as is for the special event count.

6mp commented 1 year ago

To include unconfirmed drivers I will have to make a new rollup property in the Supplier Pickup Events table which will account for them. How should I go about doing this so it can be done on the live airtable also?

henrygreenhut commented 1 year ago

@6mp The roll-up property it's pulling from is called "Only Driver Count" in Airtable, which is somewhat misleadingly named as it's really the count of confirmed volunteers who are only driving. The count of only packers is doing the same thing, pulling from a property filtered to only count confirmed records. To create a property for confirmed and unconfirmed drivers, you can just duplicate the only driver count property and remove the confirmed filter. Unless I'm misunderstanding how it all works, I believe you can just make this property in the development base and live base and just name the properties the same.

6mp commented 1 year ago

@hgreenhut Thank you that is exactly what I am doing.

6mp commented 1 year ago

I made the appropriate changes in the test and prod airtables. The new fields are called Only Distributor Count Including Unconfirmed and Only Driver Count Including Unconfirmed respectively. I didn't edit the original fields since I dont want to disrupt anything that depends on them as they are.

mattsahn commented 1 year ago

@6mp, I think we also need an "Driver and Distributor Count Including Unconfirmed", too. The "#Driving & Packing" count shows as zero, but there are 5 "Driving & Packing" signups for 7/29, they just haven't been confirmed yet.

image

current app shows the 5: image

6mp commented 1 year ago

I have addressed that in this commit @mattsahn