search

grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
10 stars 5 forks source link

Fixed the location of where to fetch the text message body from the b… #119

Closed mattsahn closed 1 year ago

mattsahn commented 1 year ago

Description of this change

Fixed the location of the text message body in the response of /api/messaging/locations-to-drivers-text/ response. It had moved due to the Make scenario changing recently and this part of code needs to be updated. This is a temporary fix as we need something long term that is not fragile.

Screenshots (for UI changes - otherwise delete this section)

Before this PR:

image

After this PR:

image

railway-app[bot] commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ◻️ REMOVED

6mp commented 1 year ago

This looks good, I could also look into using the make api to fetch this in a more official way so we dont run into this issue anymore.

https://www.make.com/en/api-documentation/scenarios

mattsahn commented 1 year ago

This looks good, I could also look into using the make api to fetch this in a more official way so we dont run into this issue anymore.

https://www.make.com/en/api-documentation/scenarios

Sure, please do. We're using the Make API to fetch the scenario blueprint, which is an official API, but it's a moving target to pick out where the text body happens to be if you make significant changes to the scenario. I can't think of a great solution for this other than to take a different approach, but see what you can come up with.