grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
11 stars 6 forks source link

129 modal rework #131

Closed jasoncavanaugh closed 1 year ago

jasoncavanaugh commented 1 year ago

129

Description of this change

Reworked modals to look better on mobile. Added --host flag to Vite dev server to make mobile development easier. Also got rid of VITE_SERVER_URL in frontend code and instead am proxying code back to localhost:5000 using Vite because the old method of proxying was causing issues when trying to develop locally on a mobile device.

Screenshots (for UI changes - otherwise delete this section)

Before this PR:

image image image image image

image image image image image

After this PR:

image image image image image

image image image image image

Checklist

railway-app[bot] commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ◻️ REMOVED

zuechai commented 1 year ago

Just tested the deployment on my phone (using an iPhone 12 Pro Max): Modals for Send Locations to Drivers and Send Driver Info to Coordinators in Delivery and Location Info trigger the overlay on mobile, but the modal doesn't populate in view. Same for Recruit Coordinators and Recruit Volunteers. The other modals populate within view fine for me otherwise.

image

image

I think for mobile having a slight border around scrollable content and/or mobile scroll bar would help to differentiate the sections of content within the modals.

image

image

jasoncavanaugh commented 1 year ago

Ah good catch. I had forgotten that we had added modals for those buttons. Will try to update later today.

jasoncavanaugh commented 1 year ago

Fixed up text message modals not displaying. Also made location information modal look a bit nicer, despite the fact that that part of the UI will probably have to be redesigned.

zuechai commented 1 year ago

Nothing from me. This looks good and worked well in the deployment.