147 revamp assign locations

jasoncavanaugh commented 1 year ago

Description of this change

Screenshots (for UI changes - otherwise delete this section)

Before this PR:

\<screenshot(s)>

After this PR:

\<screenshot(s)>

Checklist

[ ] Added link to existing Issue (created issue if there wasn't one already)
[ ] Added screenshots before/after for UI changes
[ ] PR is from branch pushed to this repo so that it will trigger Railway PR deployment
[ ] Code follows the style of this project

railway-app[bot] commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ◻️ REMOVED

mattsahn commented 1 year ago

I tried this out yesterday when there was active data/records for yesterday's event and it looked to be working well and a big improvement. I didn't get a chance to test too extensively, though, and now there's no active data in the live DB. @jasoncavanaugh are there good sample records for one of the events to test with in one of the test DBs?

Not really related to this PR, but for the driver table, it seems showing the actual location info, rather than just the ability to see it via a popup would be more helpful as one of the columns, though I can see there's not much real estate. Maybe some other columns would be better to remove and leave for popup. I can get feedback from @danthefridgeman on that and start a different issue.

@6mp , @zuechai would be great if you can do a deeper review of the code changes here before we merge.

danthefridgeman commented 1 year ago

Good reminder that Jason and I need to get together to discuss UX!

On Sun, Oct 15, 2023 at 11:16 AM Matt Sahn @.***> wrote:

I tried this out yesterday when there was active data/records for yesterday's event and it looked to be working well and a big improvement. I didn't get a chance to test too extensively, though, and now there's no active data in the live DB. @jasoncavanaugh https://github.com/jasoncavanaugh are there good sample records for one of the events to test with in one of the test DBs?

Not really related to this PR, but for the driver table, it seems showing the actual location info, rather than just the ability to see it via a popup would be more helpful as one of the columns, though I can see there's not much real estate. Maybe some other columns would be better to remove and leave for popup. I can get feedback from @danthefridgeman https://github.com/danthefridgeman on that and start a different issue.

@6mp https://github.com/6mp , @zuechai https://github.com/zuechai would be great if you can do a deeper review of the code changes here before we merge.

— Reply to this email directly, view it on GitHub https://github.com/grassrootsgrocery/admin-portal/pull/148#issuecomment-1763421101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAWI55J6ZEHQUO3WB4XKODX7P447AVCNFSM6AAAAAA57KW7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGQZDCMJQGE . You are receiving this because you were mentioned.Message ID: @.***>

--

Dan Zauderer Founder, Grassroots Grocery 917-497-2514

Check us out on Kelly Clarkson http://www.grassrootsgrocery.org/grassroots-on-kelly! Make a gift here http://www.grassrootsgrocery.org/donate!

Note, I honor and respect boundaries around personal time, self-care, caregiving, and rest. If you receive correspondence from me during a time when you’re engaging in any of the above, please protect your energy and respond when you have the capacity.

zuechai commented 1 year ago

I can review it this evening.

On Sun, Oct 15, 2023 at 11:26 AM danthefridgeman @.***> wrote:

Good reminder that Jason and I need to get together to discuss UX!

On Sun, Oct 15, 2023 at 11:16 AM Matt Sahn @.***> wrote:

I tried this out yesterday when there was active data/records for yesterday's event and it looked to be working well and a big improvement. I didn't get a chance to test too extensively, though, and now there's no active data in the live DB. @jasoncavanaugh https://github.com/jasoncavanaugh are there good sample records for one of the events to test with in one of the test DBs?

Not really related to this PR, but for the driver table, it seems showing the actual location info, rather than just the ability to see it via a popup would be more helpful as one of the columns, though I can see there's not much real estate. Maybe some other columns would be better to remove and leave for popup. I can get feedback from @danthefridgeman https://github.com/danthefridgeman on that and start a different issue.

@6mp https://github.com/6mp , @zuechai https://github.com/zuechai would be great if you can do a deeper review of the code changes here before we merge.

— Reply to this email directly, view it on GitHub < https://github.com/grassrootsgrocery/admin-portal/pull/148#issuecomment-1763421101>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AXAWI55J6ZEHQUO3WB4XKODX7P447AVCNFSM6AAAAAA57KW7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGQZDCMJQGE>

. You are receiving this because you were mentioned.Message ID: @.***>

--

Dan Zauderer Founder, Grassroots Grocery 917-497-2514

Check us out on Kelly Clarkson http://www.grassrootsgrocery.org/grassroots-on-kelly! Make a gift here http://www.grassrootsgrocery.org/donate!

Note, I honor and respect boundaries around personal time, self-care, caregiving, and rest. If you receive correspondence from me during a time when you’re engaging in any of the above, please protect your energy and respond when you have the capacity.

— Reply to this email directly, view it on GitHub https://github.com/grassrootsgrocery/admin-portal/pull/148#issuecomment-1763423845, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARWFW6JY2ZRNOUVIRF2BRJDX7P6D5ANCNFSM6AAAAAA57KW7MI . You are receiving this because you were mentioned.Message ID: @.***>

danthefridgeman commented 1 year ago

I would LOVE to see it as soon as it's ready!

Dan Zauderer Founder, Grassroots Grocery 917-497-2514

Check us out on Kelly Clarkson https://t.sidekickopen69.com/Ctc/OR+23284/d2nMfk04/JkM2-6qcW6N1vHY6lZ3lkW3QYQQP6FcJ8QW6gKWC-5KT6wmW7NvvPf3FSTY1V89wSN4hC5SLW5QxscB5C6Z4ZW84X5vn4sTsRBW5fBZG994YyW-W94Q6VX3Dw_GZW1cLhQX6sw9MXVWTkcs59mqfnW23mnLL5mfr1kVk8Tml19F06LW31CDS63NMB22W5sqFR71k3GWsW4nCk1Q93N_XrW72H-Cm3xFFJRW530Rf11nvWg7N82tXlz34n1PW4bRl0j2NJ6HgW3hSCdN1LsP-kW6Vktp62THD-RW6Z2L032033b5d9NRnW04! Make a gift here https://t.sidekickopen69.com/Ctc/OR+23284/d2nMfk04/Jks2-6qcW69sMD-6lZ3llW5p9v1y22QT60W7gCDVN6Y_1gJW7kw0nX2PHBCqW6KkwFq1LnQqZW7_6QY64fQ6mmW4dDgGy7XdVY-W7BYCRb2Xwp6tW1Hh5212pt7LCW6swGWV3-k8y8W67sYxG5cCR_xW5WGL8-48DDgkW7Pq67Q5KnZ1kW4G0gjb2w3D58W1xgCHp4Jn8gLW4vsFKG6W1R0BN6ZhCmRMK7BwW5mJ_yN2r-3ztW223Lmf1qwmb-W2D_WLv3vXZ3_W9ctbZk45pVhRf1swF6d04 !

Note, I honor and respect boundaries around personal time, self-care, caregiving, and rest. If you receive correspondence from me during a time when you’re engaging in any of the above, please protect your energy and respond when you have the capacity.

On Tue, Oct 17, 2023 at 10:29 PM Anthony Zuech @.***> wrote:

@.**** approved this pull request.

LGTM. I'm not able to test it with the data as it is, but the code looks good. @mattsahn https://github.com/mattsahn I'm going to hold off merging if y'all want to test the dashboard further.

— Reply to this email directly, view it on GitHub https://github.com/grassrootsgrocery/admin-portal/pull/148#pullrequestreview-1683803824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAWI5Z5USLY3PDRU7DNHEDX745KNAVCNFSM6AAAAAA57KW7MKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBTHAYDGOBSGQ . You are receiving this because you were mentioned.Message ID: @.***>

mattsahn commented 1 year ago

Data is available now, so looking again. LGTM. Adding some before/after screenshots here, too. I live the marking in red of locations that are "restricted" for that driver. Nice touch. I do think we should add the actual assigned location name to the "Driver Information" table, but i'll write that up as a new issue.

Before:

After:

mattsahn commented 1 year ago

I would LOVE to see it as soon as it's ready! -------- Dan Zauderer Founder, Grassroots Grocery 917-497-2514 Check

@danthefridgeman, it's live now and you can see today's data with the new experience for driver assignment. Great work, @jasoncavanaugh.

danthefridgeman commented 1 year ago

Woot woot

Would love to add just a few things but Jason and I are meeting about them. He’s done an excellent job

On Sat, Oct 21, 2023 at 9:55 AM Matt Sahn @.***> wrote:

I would LOVE to see it as soon as it's ready! -------- Dan Zauderer Founder, Grassroots Grocery 917-497-2514 Check

@danthefridgeman https://github.com/danthefridgeman, it's live now and you can see today's data with the new experience for driver assignment. Great work, @jasoncavanaugh https://github.com/jasoncavanaugh.

— Reply to this email directly, view it on GitHub https://github.com/grassrootsgrocery/admin-portal/pull/148#issuecomment-1773798381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAWI57PXEQPFZVZTQE6QO3YAPH33AVCNFSM6AAAAAA57KW7MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTG44TQMZYGE . You are receiving this because you were mentioned.Message ID: @.***>

--

Dan Zauderer Founder, Grassroots Grocery 917-497-2514

Check us out on Kelly Clarkson http://www.grassrootsgrocery.org/grassroots-on-kelly! Make a gift here http://www.grassrootsgrocery.org/donate!

Note, I honor and respect boundaries around personal time, self-care, caregiving, and rest. If you receive correspondence from me during a time when you’re engaging in any of the above, please protect your energy and respond when you have the capacity.

grassrootsgrocery / admin-portal