grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
10 stars 5 forks source link

143 include guests in total participant and packer counts #159

Closed jadenar07 closed 1 month ago

jadenar07 commented 1 month ago

Description of this change

Adjusted the total participants to be an accurate representation of every person attending, including the guests. Added the proper variables to retrieve the information from the backend then made an exportable function to retrieve the real total participant count, including guests, for each event on different pages such as the event page and the event cards on the home page.

Screenshots (for UI changes - otherwise delete this section)

Before this PR:

image### image After this PR: \<screenshot(s)>

Screenshot 2024-07-17 at 3 40 32 PM

image

railway-app[bot] commented 1 month ago
🚅 Deployed to the admin-portal-pr-159 environment in Grassroots Grocery Admin Portal Service Status Web Updated (UTC)
admin-portal ◻️ Removed (View Logs) Aug 3, 2024 at 11:07 pm
mattsahn commented 1 month ago

@jadenar07, can you update the PR with description of changes and before/after screenshots, as well?

jadenar07 commented 1 month ago

@jadenar07, can you update the PR with description of changes and before/after screenshots, as well?

Updated the description

mattsahn commented 1 month ago

I notice some brief, odd behavior when loading or reloading the main page. This happens only in the deployment for this PR and not in the prod version. @jadenar07, do you see the same? I'm using chrome on windows. Haven't looked at the code closely, but imagine there's some difference or slight inefficiency. The results look fine, but see if you can track down the source of that. It's also a bit slower to refresh than the prod page.

image

jadenar07 commented 1 month ago

I notice some brief, odd behavior when loading or reloading the main page. This happens only in the deployment for this PR and not in the prod version. @jadenar07, do you see the same? I'm using chrome on windows. Haven't looked at the code closely, but imagine there's some difference or slight inefficiency. The results look fine, but see if you can track down the source of that. It's also a bit slower to refresh than the prod page.

image

image

That's quite odd, when I run the code on my end, it's showing a reload symbol for what I can assume is each event card. What's happening on mine is a slight bit different than yours. Before my change, I believe it only showed one reload symbol and was faster by a second or so. When I load into the events page with the volunteer table, it loads quickly. So the problem is likely related to some changes to the event card. I'll look at the code to try and track down the source of the inefficiency.

mattsahn commented 1 month ago

That's quite odd, when I run the code on my end, it's showing a reload symbol for what I can assume is each event card. What's happening on mine is a slight bit different than yours. Before my change, I believe it only showed one reload symbol and was faster by a second or so. When I load into the events page with the volunteer table, it loads quickly. So the problem is likely related to some changes to the event card. I'll look at the code to try and track down the source of the inefficiency.

@jadenar07, any luck yet?