grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
11 stars 6 forks source link

Fixed participant counts not counting unconfirmed special event volunteers #178

Closed henrygreenhut closed 1 month ago

henrygreenhut commented 1 month ago

Description of this change

Closes #177. This issue was because unconfirmed special event volunteers were not being included in the "Drivers Only", "Packers Only", or "Driving & Packing" counts. For instance, the "Drivers Only" total was being calculated by summing the "Only Driver Count Including Unconfirmed" property for the general event, with the "Only Driver Count" property (which only counts confirmed drivers) of each special event.

I fixed this by updating the properties of the special events that were being summed to be the properties that included unconfirmed volunteers: I replaced "Only Driver Count" with "Only Driver Count Including Unconfirmed", "Only Distributor Count" with "Only Distributor Count Including Unconfirmed", and "Driver and Distributor Count" with "Driver and Distributor Count Including Unconfirmed".

Screenshots (for UI changes - otherwise delete this section)

Before this PR:

Screenshot 2024-09-24 at 10 34 54 PM

After this PR:

Screenshot 2024-09-24 at 10 10 38 PM

Checklist

mattsahn commented 1 month ago

Can you push this to a branch in the repo so that it triggers a Railway build of the branch?