search

grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
10 stars 5 forks source link

Added auto-animate package for smoother transitions when using the Da… #39

Closed jasoncavanaugh closed 1 year ago

jasoncavanaugh commented 1 year ago

…taTable component

mattsahn commented 1 year ago

This sounds cool. In the PR description, can you also provide a preview or animated gif kind of thing to show the before/after for this change?

jasoncavanaugh commented 1 year ago

Filtering: after-auto-animate before-auto-animate Confirming participants: confirm-after-auto-animate confirm-before-auto-animate

After comparing them, I'm not so sure we actually want this anymore. I thought it would help with making it more obvious when stuff filters in and out of the table, but I think it might be unnecessary.

mattsahn commented 1 year ago

Yeah, from those previews it doesn't look like an improvement when applied to a large table. It looks jarring and more like a bug than a feature. The current behavior looks pretty good to me and at least is very fast. I imagine to get a nice looking animated table that can transition the adding/subtracting of rows that actually looks good would take some kind of bespoke capability in the table component itself. So, ok to close this one without merging from my perspective.