Closed ifiorita closed 2 months ago
i finished task #2 but i have a dumb question – I haven't used git in a while and I forget how to make my pull request. Do I just push to my local repo first and then make the request?
also can someone clarify what title of page means? Like in the header or where the url appears?
i finished task #2 but i have a dumb question – I haven't used git in a while and I forget how to make my pull request. Do I just push to my local repo first and then make the request?
Yeah, you would commit to your local repo in a new branch and then you would push that branch to the remote in GitHub. Your new branch would then show up in GitHub and you would be able to then create a pull request to merge that branch into master. Look around for tutorials, there will be plenty for the basic flow. You probably need to setup keys with Github so that you can push from your account into Github.
also can someone clarify what title of page means? Like in the header or where the url appears?
I don't follow what this is. Can you give example or paste screenshot?
By title of the page I meant do you want it to appear in the nav bar where the logo and the Forms, Logout, etc buttons are or somewhere else?
I ran @alexkulkarni's new branch locally and it works for moving the New Event up into the banner. @ifiorita, is this what you were looking for?
Still seems not quite consistent to me. "Events" goes to an actual page while "New Event" goes to a form. Seems like that should just be under the "Forms" tab maybe, until it becomes a proper page? I kind of liked the orange button with "+" sign personally, but I guess it's not clear what orange vs green buttons do. It makes sense to me that the place where you can add a new event is when you're on the "Upcoming Events" page.
@danthefridgeman, any thoughts?
existing page:
Hello!
I agree that “add Saturday event” should be on the upcoming events part of the portal as opposed to on the top bar
I also think that we should probably prioritize all of the feature suggestions, as that is more of an aesthetic one and less of a functionality one
Maybe we can prioritize the ones that add functionality?
For now I’d say to leave the other version with the red “add Saturday,” let the developer know that they did it right and got some good practice with the portal but that we just decided to go in a direction, and encourage them to bite offa ticker that’s more related to functionally than aesthetics?
Thank you all!!!
On Mon, May 29, 2023 at 10:31 AM Matt Sahn @.***> wrote:
I ran @alexkulkarni https://github.com/alexkulkarni's new branch locally and it works for moving the New Event up into the banner. @ifiorita https://github.com/ifiorita, is this what you were looking for?
[image: image] https://user-images.githubusercontent.com/15386131/241752738-5c9f634f-2d59-4af8-8437-903a0cbb1aac.png
Still seems not quite consistent to me. "Events" goes to an actual page while "New Event" goes to a form. Seems like that should just be under the "Forms" tab maybe, until it becomes a proper page? I kind of liked the orange button with "+" sign personally, but I guess it's not clear what orange vs green buttons do. It makes sense to me that the place where you can add a new event is when you're on the "Upcoming Events" page.
@danthefridgeman https://github.com/danthefridgeman, any thoughts?
existing page: [image: image] https://user-images.githubusercontent.com/15386131/241753626-8dea17be-092a-45c3-89c2-bc1c81457d9d.png
— Reply to this email directly, view it on GitHub https://github.com/grassrootsgrocery/admin-portal/issues/78#issuecomment-1567215349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXAWI57EZ7OCWTRNEA4C44DXISXMRANCNFSM6AAAAAAX5BTYBY . You are receiving this because you were mentioned.Message ID: @.***>
--
Dan Zauderer Founder, Grassroots Grocery 917-497-2514
Check us out on Kelly Clarkson http://www.grassrootsgrocery.org/grassroots-on-kelly! Make a gift here http://www.grassrootsgrocery.org/donate!
Note, I honor and respect boundaries around personal time, self-care, caregiving, and rest. If you receive correspondence from me during a time when you’re engaging in any of the above, please protect your energy and respond when you have the capacity.
The purpose of this feature is to make the home landing page feel like a home page, as opposed to a URL end point. This will also create a space that allows you to add more features/pages down the road.
Task #1: Add New Title of Page - Event Coordination Portal.
Task #2: Add Menu Options. Today we have "logout", "forms", "events" Add, "New Event"; should function as the current "+ Add Saturday Event" button. Remove "+Add Saturday Event" button from page area