search

grassrootsgrocery / admin-portal

GNU Affero General Public License v3.0
11 stars 6 forks source link

72 Frontend fix for JWT token expiration #91

Closed jasoncavanaugh closed 1 year ago

jasoncavanaugh commented 1 year ago

Also changed NODE_ENV check to check against "development" because that is how it is everywhere else in the code.

railway-app[bot] commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ◻️ REMOVED

mattsahn commented 1 year ago

This PR is being deployed to Railway 🚅

admin-portal: ✅ Success

@jasoncavanaugh, I don't understand why Railway didn't create a URL that I can go to. It says "success" but unlike the other PRs, there's no actual URL. Any idea what's going on there?

https://railway.app/project/031d77ce-b4ed-44da-afd3-6fad256781dc/service/5f8f1a3c-eba0-48c9-baee-62a891f77fda

mattsahn commented 1 year ago

I triggered it to redeploy in Railway and same thing, still no URL

jasoncavanaugh commented 1 year ago

I manually generated a url in Railway. image But I got the "Please set NODE_ENV to 'production'" message. Did you change the deployment to use "development" for PRs?

mattsahn commented 1 year ago

I manually generated a url in Railway. image But I got the "Please set NODE_ENV to 'production'" message. Did you change the deployment to use "development" for PRs?

I don't remember setting that but it was set to use "dev" and other development env vars. I changed to the prod ones and it's working now. I'll see where that came from, if it's a global PR setting. I was trying to set that for the other deployment that's intended to stay connected to DEV stuff, but might have done to the wrong one.

mattsahn commented 1 year ago

I manually generated a url in Railway. image But I got the "Please set NODE_ENV to 'production'" message. Did you change the deployment to use "development" for PRs?

I don't remember setting that but it was set to use "dev" and other development env vars. I changed to the prod ones and it's working now. I'll see where that came from, if it's a global PR setting. I was trying to set that for the other deployment that's intended to stay connected to DEV stuff, but might have done to the wrong one.

Ok, here's where that happened. The PRs were set to inherit from the new development-base project that I intended to have point to dev stuff. But, there are other issues with that still with the NODE_ENV thing when deloyed on Railway, so i'll change that back to production for now.

image