search

grastello / ytel

Youtube "front-end" for Emacs
GNU General Public License v3.0
48 stars 10 forks source link

Fork or merge #14

Open spiderbit opened 4 years ago

spiderbit commented 4 years ago

I mentioned before that using tabulated-list can be a good way to as example mitigate the font-issue but also to have some good like sorting by column and so on, also I could delete some code by not loosing functionality.

So I have I don't know if rewritten is the correct word migrated is probably better your code to a tabulated-list variant in the branch. Yet I noticed a few things I forgot that makes that basically not a 1:1 replacement with some positive and some negative effects.

  1. column names are basically hardcoded and replace the title lane, so it changes the looks, the information you have in that line I had to put into the mode line.
  2. especially because I had put the search title in the buffer-name I got nearly by mistake the functionality that each search outside of this buffer creates a new buffer for this search. So you can have multiple searches open at the same time and refresh them. Which can be very useful but also be confusing I guess.

Now we share still 80-90% of the same code, but it behaves and looks pretty differently, so I would assume that you will not merge this tabulated-list code change? Here you can see a picture of it with my theme: https://github.com/spiderbit/ytel/tree/tabulated-list

If that is the case it would probably be best to find a different name for my code and make a clean cut fork? The disadvantage is that we then have to at least rename all name space references in functions and variables if we exchange commits/patches.

I should have most things implemented i want for now, I want a sort sub-buffer like the one in magit that pops up below so that you can as example press r d for sort by date and r n for sort by name... rotating through the possible sort options by repetitively press r is not ideal, but otherwise I have no current plans on further improvements.

grastello commented 4 years ago

Well, that screenshot looks very neat to me, good job.

Given that it behaves differently from the current release (as you pointed out), that I've been ignoring you quite a lot (stuff happened) and that my willingness to work on ytel is quite low at the moment I suggest you go for a fork. As for the name problem see if you can come up with something, then renaming variables and workspaces should not be a big deal as the codebase is not big and Emacs is, after all, a good text editor.