grastello
commented
4 years ago I like it.
However this does clashes with the idea I initially had for ytel i.e. that of being a "result collector" for Youtube queries. This is the idea behing having ytel-search appending results to the current ones and ytel-search-replace replacing them with entirely new ones as well as having a function to remove videos from the buffer (r).
Managing other pages of results like you're doing will clearly clash with the behaviour of ytel-search. Pulling more results in a buffer with already some videos in it will "corrupt" the header substituting the old search terms with the new ones even if results of serching the old terms are still present.
Yet again I have been thinking that this whole "youtube result collector" thing I had in mind is not that great of an idea. I never find myself using r to remove videos from the buffer and I never add new ones with s (ytel-search) because there's no way to distinguish them from the old ones. I feel that going for something like what you presented here is the way to go.
As for the code it seems good to me. I've just fixed some docstrings (or rather had M-x checkdoc do it). I'll give the stuff above some more thought but I'll probably merge this PR in a couple of hours (and then get rid of the clashing behaviour).
Thank you!
I think this is a much more intuitive way to search the next page of a search. Simply pressing the "<,>" keys to navigate forward and backward. I also added a header so you can see in which page you're in, with the potential of adding other kind of useful information.
Let me know what you think.