zbynekwinkler commented 10 years ago

We do not have a tests for:

www/for/index.html.spt
www/for/%slug/index.html.spt
www/%username/horn/toot.json.spt
www/%username/horn/toots.json.spt
www/credit-card.json.spt
www/%username/history/index.html.spt
www/about/paydays.json.spt
www/about/charts.json.spt
www/about/fraud/2012-11-05.html.spt
www/about/fraud/review.html.spt
www/about/tip-distribution.json.spt
www/about/top.json.spt
www/on/github/%login/index.html.spt
www/on/twitter/%screen_name/index.html.spt
www/on/bitbucket/%username/index.html.spt
www/bank-account-complete.html.spt
www/bank-account.json.spt

This has been found in #1737.

--- Want to back this issue? **[Place a bounty on it!](https://www.bountysource.com/issues/1350782-add-more-tests?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

zbynekwinkler commented 10 years ago

I'd like to add at least basic smoke tests for these pages - just trying GET on each one and seeing if 200 status is returned. Even such a simplified test would have helped us while removing the gittip.db global. After this I plan to go back to #1549. Without these tests I do not feel comfortable doing so. In the mean time I hope someone can review #1756.

chadwhitacre commented 10 years ago

1699 adds a test client instance to the `Harness` class so we won't need to instantiate that ad hoc any more. It also configures CSRF wiring so we no longer have to do that manually. Hopefully that will make it easier to zip through these pages.

chadwhitacre commented 10 years ago

Not finding the IRC reference right now where you asked whether to block on #1699, @zwn, but we are pretty dang close on #1699. @pjz is going to cut a new release of Aspen and then #1699 will be ready for review. I'd say let's land that first before proceeding here.

zbynekwinkler commented 10 years ago

We are also missing test for linkify #1869.

Changaco commented 9 years ago

Closing, tests for GET requests on all simplates were added in #3033.

gratipay / gratipay.com

Add more tests #1739

1699 adds a test client instance to the `Harness` class so we won't need to instantiate that ad hoc any more. It also configures CSRF wiring so we no longer have to do that manually. Hopefully that will make it easier to zip through these pages.

gratipay / gratipay.com

Add more tests #1739

1699 adds a test client instance to the Harness class so we won't need to instantiate that ad hoc any more. It also configures CSRF wiring so we no longer have to do that manually. Hopefully that will make it easier to zip through these pages.

1699 adds a test client instance to the `Harness` class so we won't need to instantiate that ad hoc any more. It also configures CSRF wiring so we no longer have to do that manually. Hopefully that will make it easier to zip through these pages.