search

gratipay / gratipay.com

Here lieth a pioneer in open source sustainability. RIP
https://gratipay.news/the-end-cbfba8f50981
MIT License
1.12k stars 308 forks source link

Check for and clear tips to a deactivated account #1932

Closed bruceadams closed 10 years ago

bruceadams commented 10 years ago

After deactivating jashkenas, they sent an email to support saying:

It appears that even after being cancelled, if I load gittip.com, it says this in the corner:

deactivated-jashkenas – sign out Giving: $1.00/wk Receiving: $30.00/wk

I asked @whit537 to take a look, he says:

We needed to log them out by setting session_token to null. I've done now this for all 11 deactivated-% users and have updated https://github.com/gittip/www.gittip.com/issues/54#issuecomment-29240281. So we can tell Jeremy that he has been logged out (and could he confirm that?) and we haven't moved any money to his account.

I checked the transfers table and the last transfers we did for jashkenas were from Jan 9. We've had one payday since then, on Jan 16, so it looks like we haven't moved any money to him since then.

I'm getting a 500 on https://www.gittip.com/deactivated-jashkenas/history/ so I can't check that view. Here's the error: https://app.getsentry.com/gittip/gittip/group/13874404/.

Looking at the tips table, I see the zeroing out to jashkenas on the 13th, but then I do see four tips recorded (from one tipper) on the 14th and 15th. The ctime is actually on the 14th, so this appears to be a problem, and one we should resolve before payday this week to avoid moving money to the deactivated-jashkenas account. Could you please make a new GitHub ticket for this and mark it three stars?

chadwhitacre commented 10 years ago

Thankfully, it doesn't appear that we transferred money to deactivated-jashkenas this week. Why is that? My hunch is that we include claimed_time in the query for participants during payday. Yup. So that's good. :-)

It's still a bug that andyet was able to tip deactivated-jashkenas after he was deactivated. Looks like it's time for another self-check, @zwn. :-)

chadwhitacre commented 10 years ago

I'm dropping this to ★★☆ since we don't actually move money in this case.

zwn commented 10 years ago

It's still a bug that andyet was able to tip deactivated-jashkenas after he was deactivated. Looks like it's time for another self-check,@zwnhttps://github.com/zwn. :-)

I don't think this is a bug. There is actually no code that prevents it :astonished:. Cf. #1705

zwn commented 10 years ago

How can we tell that a user is deactivated? Unsetting claimed_time without deleting appropriate elsewhere returns 500. See https://www.gittip.com/deactivated-jashkenas/. What it is we should forbid when fixing tipping to deactivated accounts? Because I was able to tip 6a2ab9485317 just fine. We need a definition of deactivated account.

seanlinsley commented 10 years ago

deactivated-jashkenas is showing up as a top receiver on the Ruby community page, which is especially unfortunate since it's a user-facing link that results in a 500. (@zwn and I discussed this a bit on IRC)

chadwhitacre commented 10 years ago

deactivated-jashkenas is showing up as a top receiver on the Ruby community page

Blech. Gross. :-(

Bumping back up to ★★★.

sferik commented 10 years ago

:+1: Just got a 500 error as a result of this issue.

Changaco commented 10 years ago

This was fixed by #2507.