search

gratipay / gratipay.com

Here lieth a pioneer in open source sustainability. RIP
https://gratipay.news/the-end-cbfba8f50981
MIT License
1.12k stars 310 forks source link

Add a simple field to collect info re: projects #4641

Closed chadwhitacre closed 6 years ago

chadwhitacre commented 6 years ago

One notch better than a note to email us. I think this is important to our pitch to companies, per https://github.com/gratipay/inside.gratipay.com/issues/987#issuecomment-304707443.

chadwhitacre commented 6 years ago

Ping @JessaWitzel @mattbk @dmk246 @rohitpaulk et al. for review!

chadwhitacre commented 6 years ago

I have an email ready to send to Yahoo once this is deployed.

mattbk commented 6 years ago

Eep! Mind looking over your info for us?

None of the fields is highlighted...

I'm getting this error irregularly.

mattbk commented 6 years ago

I get that error for all values above $1999. I think this is reason for error above.

Also can't enter decimals, even .00.

mattbk commented 6 years ago

I get that error for all values above $1999.

Same for master.

mattbk commented 6 years ago

Just testing? Other than that it works for me and things show up in db.

https://github.com/gratipay/gratipay.com/blob/aec50084e6a5bd28598ee417f4fa3e2e003225e4/gratipay/card_charger.py#L64

chadwhitacre commented 6 years ago

Yeah if you wire up a Braintree sandbox and turn the form on, then the CC form fields should highlight red when the amount is 2000+.

screen shot 2017-09-20 at 12 23 19 pm

chadwhitacre commented 6 years ago

Actually, I maybe lied ...

chadwhitacre commented 6 years ago

Alright, I see what you mean about the bad dollar amounts which simulate card charging problems not showing up with an error message in the UI. I don't think this PR introduces that problem though so can we reticket and proceed here?

mattbk commented 6 years ago

Not a problem for me.

chadwhitacre commented 6 years ago

Reticketed https://github.com/gratipay/gratipay.com/issues/4649.