search

gratipay / gratipay.com

Here lieth a pioneer in open source sustainability. RIP
https://gratipay.news/the-end-cbfba8f50981
MIT License
1.12k stars 308 forks source link

Re-fix #4597 because I borked it again in #4590 #4643

Closed chadwhitacre closed 7 years ago

chadwhitacre commented 7 years ago

Ping @clone1018 @rohitpaulk @mattbk et al. 😬

chadwhitacre commented 7 years ago

Okay not sure what's up.

Done.
rm i18n/*.pot
env/bin/tx pull -a -f --mode=reviewed --minimum-perc=50
Pulling translations for resource gratipay.core (source: i18n/core.pot)
Skipping 'eo' translation (file: i18n/core/eo.po).
 -> nl: i18n/core/nl.po
Skipping 'pt' translation (file: i18n/core/pt.po).
Skipping 'ko' translation (file: i18n/core/ko.po).
 -> de: i18n/core/de.po
Skipping 'tr' translation (file: i18n/core/tr.po).
 -> fr: i18n/core/fr.po
 -> it: i18n/core/it.po
 -> ja: i18n/core/ja.po
 -> es: i18n/core/es.po
Done.
[master 59e0c71] Update i18n files
 6 files changed, 144 insertions(+), 108 deletions(-)
Tag and deploy version 2116? (y/n) y
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
Changes not staged for commit:
        modified:   deploy.sh

Untracked files:
        irs.sql
        log
        match-2015.py
        matches.csv
        transaction_search.csv

no changes added to commit
$ gb
  fix-deploy-again
* master
$ gs
 M deploy.sh
?? irs.sql
?? log
?? match-2015.py
?? matches.csv
?? transaction_search.csv
chadwhitacre commented 7 years ago

www/version.txt is still 2116 so I guess echo never ran? yesno failed, is that it?

https://github.com/gratipay/gratipay.com/blob/ee8fa9fc43577c0f61a11ca5f782864e4acef19c/deploy.sh#L72

chadwhitacre commented 7 years ago

Maybe I typed y (extra space) or something?

chadwhitacre commented 7 years ago

Wait ... why are we tagging and deploying 2116 when 2116 is already deployed? 😶

Tag and deploy version 2116? (y/n) y
chadwhitacre commented 7 years ago

Looking at recent history I see we deployed 2116 a few days ago. Hmm ... 🤔

chadwhitacre commented 7 years ago 
$ git describe --tags --match '[0-9]*'
2115-16-gee8fa9f
$
chadwhitacre commented 7 years ago 
$ git tag|grep 211
2110
2111
2112
2113
2114
2115
$
chadwhitacre commented 7 years ago

Maybe we failed to tag as part of deploying 2116?

chadwhitacre commented 7 years ago

I remember doing some sort of goofy commenting of deploy.sh to finish a crashed deployment (iirc due to the network card flakiness I'm having), but 2116 was @rohitpaulk. Anything irregular about deploying 2116, @rohitpaulk?

chadwhitacre commented 7 years ago

Okay I tagged 2e9816e.

$ gp --tags
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:gratipay/gratipay.com.git
 * [new tag]         2116 -> 2116
$
chadwhitacre commented 7 years ago

While I'm at it I keep seeing this "new branch" show up all the time. Why all the time?

$ ./deploy.sh 
From github.com:gratipay/gratipay.com
 * [new branch]      limit-verifications-in-UI -> origin/limit-verifications-in-UI
Already up-to-date.
...
chadwhitacre commented 7 years ago

👍

Tag and deploy version 2117? (y/n)
chadwhitacre commented 7 years ago

Okay! I got #4641 deployed using the change on this PR. 👍