search

gratipay / grtp.co

Gratipay Widgets + API
https://grtp.co/
MIT License
26 stars 19 forks source link

Fixed $null error #59

Closed jeroenvisser101 closed 10 years ago

jeroenvisser101 commented 10 years ago

There was an error that made 'null' display on the widget.

chadwhitacre commented 10 years ago

Thanks @jeroenvisser101! :-)

chadwhitacre commented 10 years ago

@rummik What's our deploy process for gttp.co?

jeroenvisser101 commented 10 years ago

You're very welcome :)

jeroenvisser101 commented 10 years ago

Note: due to the repo not being deployed, this issue still persists. /cc @rummik

rummik commented 10 years ago

Uh, oops. I don't have deployment set up locally (new computer) I'll try and write deploy instructions while I do that tomorrow.

Changaco commented 10 years ago

Copying my comment from gittip/www.gittip.com#2648:

For the record, null means that the user has chosen to hide his/her receiving amount by checking "Hide total receiving from others" in https://www.gittip.com/about/me/account/.

So showing $0.00 in the widget isn't accurate.

rummik commented 10 years ago

@whit537 The deploy process is git push gttp@gttp.co, you just need to have your SSH public key in .ssh/authorized_keys. All my drives are LUKS encrypted, and I haven't had time to set up Linux properly on my new laptop (there's some boot issues with most distros due to EFI), so I can't deploy for the moment. I was planning on getting it set up last weekend, but wasn't able to find the time... >.>;

jeroenvisser101 commented 10 years ago

My tests showed something else, it was also showing null when someone had it on 'public' and was just not earning anything. /cc @Changaco

Changaco commented 10 years ago

@jeroenvisser101 It might have been so in the past, but the current code behind public.json only returns null when anonymous receiving is turned on.

jeroenvisser101 commented 10 years ago

@Changaco that would explain the thing. The best thing then, is to revert this change, as it breaks functionality.

rohitpaulk commented 10 years ago

@jeroenvisser101 @Changaco - I just pushed a PR related to anonymous giving/receiving behaviour. Do you think this solves the issue mentioned here?

jeroenvisser101 commented 10 years ago

@rohitpaulk Yes, I think so. Not sure if this PR still has to be reverted. I don't think so, because you've overwritten the changes. I am not experiencing the errors anymore, thanks!