Switch to Gulp? - Githubissues

gratipay / grtp.co

Gratipay Widgets + API

https://grtp.co/

MIT License

26 stars 19 forks source link

Switch to Gulp? #77

Closed rummik closed 8 years ago

rummik commented 9 years ago

I've been playing with Gulp for a while now, and really love its use of streams and support for incremental builds. Seems like it would be a great idea to switch over to reduce build times, and testing time.

techtonik commented 9 years ago

rummik commented 9 years ago

@techtonik Two points that post doesn't cover:

Watchers - Right now we have grunt watch, and would have an equivalent Gulp task for watching for changes, so when a file is written it'll automatically build it locally, saving you a lot of time.
Incremental builds - With incremental builds, only the files affected by the change are rebuilt, which a npm jshint or npm uglify wouldn't handle. Yes, we could roll our own watchers, but I don't personally see it as being worth the time investment.

clone1018 commented 9 years ago

+1 gulp

techtonik commented 9 years ago

Looks like watch is possible - http://blog.keithcirkel.co.uk/how-to-use-npm-as-a-build-tool/#watch but I do not insist.

galuszkak commented 9 years ago

+1 for gulp.

@techtonik in my experience gulp is much more handy, than plain tasks defined in package.json . One thing to point out is (IMO) that it is also much more readable.

techtonik commented 9 years ago

Grunt gave me some headache when I was tuning Vagrant, and browser jstests still fail to run. Will going Gulp fix that? https://github.com/gratipay/gratipay.com/issues/3000

techtonik commented 9 years ago

Info how to do testing with Gulp - http://twin.github.io/selenium-testing-workflow-with-webdriverio/

techtonik commented 8 years ago

Working on that yesterday/today.

rummik commented 8 years ago

@techtonik There's a lot of work towards this in the v2 branch

techtonik commented 8 years ago

@rummik https://github.com/gratipay/grtp.co/pull/81 looks like a big step to complete (and test are failing). Can we just factor out Gulp part into Widgets 1.5 PR? In that case I will be able to review and merge it without QR part. I prefer to tasks in single gulpfile.js for direct comparison with Grunt.

In my PR - https://github.com/gratipay/grtp.co/pull/108 - I also started to introduce ESLint instead of JSHint, so I am afraid that more time we spend on PR, the more features creep in. Perhaps you can give me a review and/or add commits to that gulp branch to make it complete?

rummik commented 8 years ago

@techtonik I probably won't have time to do that until the weekend at the soonest, but I'll see what I can do

techtonik commented 8 years ago

@rummik would be awesome!

chadwhitacre commented 8 years ago

This seems to have stalled out.