search

gratipay / grtp.co

Gratipay Widgets + API
https://grtp.co/
MIT License
26 stars 19 forks source link

Replace minify task with deploy that also copies Blogger widget files #91

Closed techtonik closed 9 years ago

techtonik commented 9 years ago

Ready for review. Ping @rummik =)

techtonik commented 9 years ago

Ping again.

techtonik commented 9 years ago

You can test it at https://codenvy.com/ws/techtonik/grtp.co (needs login to run and watching short intro to find the controls).

rummik commented 9 years ago

I feel like it should be called build rather than deploy

techtonik commented 9 years ago

Well, copying files to www/ looks like deployment to me. Anyway, if we about to switch to Gulp, we can name it differently from the start there.

rummik commented 9 years ago

I usually separate by deploy being deployment to a server, building being compiled/minified, and install being copying it to a system-wide location rather than a local build. It's also more consistent with the Grunt and Gulp naming for tasks (which often includes minify as a task separate to build)

techtonik commented 9 years ago

And I thought that scripting languages are easier than C/C++.. Let me fix that in a minute. )

techtonik commented 9 years ago

@rummik, done!

techtonik commented 9 years ago

@rummik ?

techtonik commented 9 years ago

Ping.

techtonik commented 9 years ago

Anybody? @rummik @whit537 @rohitpaulk

chadwhitacre commented 9 years ago

Doesn't look actively dangerous to me and @rummik appears to be away on other business. Merging! :-)

techtonik commented 9 years ago

!m @whit537 Thanks. =) Now somebody needs to run deployment in #83.