gratrix / vcv-gratrix

Gratrix modules for VCV Rack
http://gratrix.net/vcvrack
MIT License
30 stars 6 forks source link

MIDI-C1/G1 (Core Quad MIDI to CV bug fixes) #5

Open Uriel-A opened 6 years ago

Uriel-A commented 6 years ago

Hi,

You mentioned in your manual that your modules are based on the VCV core modules code. There have been a few important bug fixes recently to the Quad MIDI to CV over at VCV that you might want to take a look at and perhaps implement to your own modules. Namely https://github.com/VCVRack/Rack/issues/549 and https://github.com/VCVRack/Rack/issues/535.

I've also encounter another different bug (certain notes stops working) that only manifest in your MIDI-C1/G1 modules but I'm not sure whether if it's caused by the above mention issues. If you can implement the new fixes maybe I can do a better test on yours and report back.

gratrix commented 6 years ago

Thank you for reporting these, and sorry for not getting back sooner (had a lot on). I will certainly bring in the fixes which I think should do the trick as I have only made minimal changes. Should have it done in a few days.

gratrix commented 6 years ago

So taken a look at the 0.6.0dev source and MIDI has changed a bit. My plan now is to go straight to 0.6, which should also fix the issues. Will keep you posted.