search

gratrix / vcv-gratrix

Gratrix modules for VCV Rack
http://gratrix.net/vcvrack
MIT License
30 stars 6 forks source link

Fix upstream macro conflict for clean build against v0.6 bleeding edge #9

Closed zrnsm closed 5 years ago

zrnsm commented 6 years ago

These debug methods cause the build to fail because upstream there is a macro called 'debug' defined now. This actually broke a couple of other plugins too annoyingly. Just changing the method names resolves it.

zrnsm commented 6 years ago

Hi Daniel. This looks like the error that happens without my fix at commit d37bf72. You need to make sure that where you are building you have the commit from this PR (7e4381b). You can add my fork as a remote or check it out, etc. Or you can make the change manually just to get it working.

573 commented 6 years ago

Hi Nicolas, sorry for the fuzz. Had indeed some leftover files lying around, building cloned https://github.com/nicolasmiller/vcv-gratrix.git with the contained 7e4381b is running like a charm. Hope the PR can be accepted soonish.

gratrix commented 5 years ago

Cheers. :)