search

grattan / R_at_Grattan

Using R at Grattan
https://grattan.github.io/R_at_Grattan/
Creative Commons Zero v1.0 Universal
7 stars 3 forks source link

introduction to R drafted #15

Closed MattCowgill closed 5 years ago

MattCowgill commented 5 years ago

not going to do further work on this for at least a few days

MattCowgill commented 5 years ago

ps @wfmackey I'm unsure about our workflow on this. If I'm working on a chapter in a branch, should I:

  1. Only do a PR from branch -> master when the chapter is complete;
  2. Do a PR from branch -> master whenever I complete some milestone, and leave the branch active; or
  3. Do a PR from branch -> master whenever I complete some milestone, and delete the branch until I intend to do further work on the chapter.

What do you think?

wfmackey commented 5 years ago

ps @wfmackey I'm unsure about our workflow on this. If I'm working on a chapter in a branch, should I:

  1. Only do a PR from branch -> master when the chapter is complete;
  2. Do a PR from branch -> master whenever I complete some milestone, and leave the branch active; or
  3. Do a PR from branch -> master whenever I complete some milestone, and delete the branch until I intend to do further work on the chapter.

What do you think?

I think 2 is the way to go. It works when individual people are working on individual chapters, and that will be our dominant style (at least during the first-draft stage).

If I wanted to add something to one of your chapters, I guess I would create new branch (chapter_x_wfm) based off the main chapter branch (chapter_x); make my changes; then PR to chapter_x_wfm -> chapter_x.

That works in my head. Can you see any complications?

MattCowgill commented 5 years ago

yep that works, thanks Willy