search

grattan / grattex

7 stars 6 forks source link

Option for embargoed #33

Closed HughParsonage closed 7 years ago

Cam-chisholm commented 8 years ago

Does this mean you want me to do this, or just review?

HughParsonage commented 8 years ago

Review. In general, assigned to a pull request means review the pull request. Assigned to an issue means resolve the issue.

Cam-chisholm commented 7 years ago

Actually, one suggested change - \EmbargoDate should be a valid command even if the option is not specified. At the moment the presence of \EmbargoDate causes an error if the option is not specified

HughParsonage commented 7 years ago

Hmm I disagree actually. But the command should emit a nicer error -- explaining that the option needs to be enabled.

Cam-chisholm commented 7 years ago

My concern was more on the other end - just before publication it will be necessary to remove the option and the \EmbargoDate (we're talking valuable seconds here...)