search

grattan / grattex

7 stars 6 forks source link

Bib additions #86

Closed HughParsonage closed 7 years ago

HughParsonage commented 7 years ago

Bib entries from NEM and Cutting a better drug deal

@Cam-chisholm Not feasible to review every entry of course, but take a quick (<1 min) squizz and see if you notice any bad entries.

Cam-chisholm commented 7 years ago

Didn't notice any obvious bad entries, but there are a couple of urls with %, $, and & - does this cause an error?

HughParsonage commented 7 years ago

No - the unit tests would pick this up.

Shouldn't use \% in urls -- this breaks the hyperlink. On Wed, 20 Sep 2017 at 10:01 am, Cameron Chisholm notifications@github.com wrote:

Didn't notice any obvious bad entries, but there are a couple of urls with %, $, and & - does this cause an error?

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/HughParsonage/grattex/pull/86#issuecomment-330706915, or mute the thread https://github.com/notifications/unsubscribe-auth/AHvGDGbOqKdwACcClC78V4x5LXkzEx2sks5skFXTgaJpZM4PcbqM .

camchisholm commented 7 years ago

That’s what I thought – I noticed a % on line 1531 (which isn’t a new entry)

From: HughParsonage [mailto:notifications@github.com] Sent: Wednesday, 20 September 2017 10:15 AM To: HughParsonage/grattex grattex@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [HughParsonage/grattex] Bib additions (#86)

No - the unit tests would pick this up.

Shouldn't use \% in urls -- this breaks the hyperlink. On Wed, 20 Sep 2017 at 10:01 am, Cameron Chisholm <notifications@github.com mailto:notifications@github.com > wrote:

Didn't notice any obvious bad entries, but there are a couple of urls with %, $, and & - does this cause an error?

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/HughParsonage/grattex/pull/86#issuecomment-330706915, or mute the thread https://github.com/notifications/unsubscribe-auth/AHvGDGbOqKdwACcClC78V4x5LXkzEx2sks5skFXTgaJpZM4PcbqM .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HughParsonage/grattex/pull/86#issuecomment-330708919 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKyG4GWSf6US9UXT9yZmfEruxMgLAF_Oks5skFkFgaJpZM4PcbqM . https://github.com/notifications/beacon/AKyG4OLdY88Jit8QQyCeTeqh0bW4_d8Qks5skFkFgaJpZM4PcbqM.gif