graulund / tweetnest

NO LONGER MAINTAINED. MESSAGE ME IF YOU WANT TO MAINTAIN THIS. :) A browsable, searchable and easily customizable archive and backup for your tweets
MIT License
492 stars 93 forks source link

Browser-detection issue #52

Open RobThree opened 11 years ago

RobThree commented 11 years ago

Line 52 of tweets.js contains:

if($.browser.msie && $.browser.version < 8){

This causes a JS error: "Uncaught TypeError: Cannot read property 'msie' of undefined". This is because jQuery deprecated the feature in 1.3 and since 1.9 it has been removed entirely.

If it were up to me I'd drop support for IE < 8 so the entire shim can be removed; if you insist on supporting older browsers you need to find a better way (modernizr might be a good option, 'future proof' but, imho, way overkill) to detect browser version/features.