graveyard / gearcmd

Utility to create gearman workers out of command-line programs
Apache License 2.0
13 stars 0 forks source link

Move completely to go15 #29

Closed christiangriset closed 9 years ago

christiangriset commented 9 years ago

For context, see https://clever.atlassian.net/browse/INFRA-1112

This PR was autogenerated. @nathanleiby you were chosen as the most active commiter of this repo, please review and check that builds still pass.
Some known, but difficult to automate, errors are:

If there are any problems, feel free to ping @cgclever for troubleshooting.

For understanding Godeps and vendoring see this doc.

Thank you!

nathanleiby commented 9 years ago

having issues with dependency on raven-go

# cd .; git --git-dir=/var/cache/drone/src/github.com/getsentry/raven-go/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'docs/_sentryext'
package github.com/getsentry/raven-go: exit status 1
make: *** [github.com/Clever/gearcmd/cmd/gearcmd] Error 1

cc: @cgclever have we resolved this already in other repos?

christiangriset commented 9 years ago

@nathanleiby: tl;dr, needed to add vendored deps.

What happened here was a deficiency of the gitbot script. It wasn't smart enough to know that there were some repos which need vendoring, though they didn't before. This is an example of a repo which ran go get -d -t in the Makefile, so there was never any reference to vendoring (so the script chose not to). This change removed said go get command from the Makefile and added the appropriate vendoring.

nathanleiby commented 9 years ago

thanks for the fix!