graveyard / gearcmd

Utility to create gearman workers out of command-line programs
Apache License 2.0
13 stars 0 forks source link

handle temporary work directories #38

Closed natebrennand closed 8 years ago

natebrennand commented 8 years ago

This PR adds support for creating and removing a temporary work directory. The directory is "passed" to the process through the environment variable, WORK_DIR. This is work that is currently repeated (usually inconsistently) in every one of our workers, it should be standardized to clean up our workers.

This PR also converts all log calls to use kayvee.logger.

I intend to increment the minor version (unless there's disagreement).

CC @azylman

kvigen commented 8 years ago

this looks good, just a few questions

natebrennand commented 8 years ago

Reassigning for review because last refactor was nontrivial

kvigen commented 8 years ago

lgtm, just the one comment about directory cleanup in the retry case