graveyard / gearcmd

Utility to create gearman workers out of command-line programs
Apache License 2.0
13 stars 0 forks source link

DIS2-975 kill pgid #63

Closed johnhuangclever closed 7 years ago

natebrennand commented 7 years ago

Question on testing is still standing

johnhuangclever commented 7 years ago

Tested locally using some scripts similar to the original gaprov-worker script:

#!/bin/bash
# test.sh

echo "starting"
node_modules/.bin/coffee test_script.coffee $1
echo "okay"
sleep 3m
echo "done"
# test_script.coffee
console.log process.argv

setTimeout ->
  console.log("done")
, 600000000

Ran locally:

build/gearcmd-v0.8.7-darwin-amd64/gearcmd -parseargs=false -name john -cmd ./test.sh -cmdtimeout 5s -host=clever-dev--gearmand.int.clever.com -port=4730

master build leaves coffeescript processes around:

johnhuang:~/go/src/github.com/Clever/signalfx-metadata-sync$ ps -o pgid -ef | less -i
johnhuang:~/go/src/github.com/Clever/signalfx-metadata-sync$ ps -o pgid -ef | grep coffee
PGID   UID   PID  PPID   C STIME   TTY           TIME CMD
26426   501 26427     1   0  6:44PM ttys005    0:00.22 node node_modules/.bin/coffee test_script.coffee {"district_id":"55b0160f4307c901000001c6"}
26434   501 26435     1   0  6:44PM ttys005    0:00.25 node node_modules/.bin/coffee test_script.coffee {"district_id":"55b0160f4307c901000001c6"}

This branch cleans them all up