Default `pass-sigterm` to `true`

graveyard / gearcmd

Utility to create gearman workers out of command-line programs

Apache License 2.0

13 stars 0 forks source link

Default `pass-sigterm` to `true` #67

Closed nathanleiby closed 6 years ago

nathanleiby commented 6 years ago

We make this the default in order to match signal handling behavior in sfncli (https://github.com/Clever/sfncli). We want to know ahead of time if any application isn't handling sigterm correctly.

Migration plan:

release this
move all gearcmd apps to v0.10.0
if anything breaks due to signal handling problems, set pass-sigterm=false temporarily until we can solve the issue
(time passes)
Migrate to workflows

johnhuangclever commented 6 years ago

huzzah!

nathanleiby commented 6 years ago

@johnhuangclever thanks!