graveyard / godoc-docker

Docker image holding a standalone godoc server
13 stars 4 forks source link

Enabling docker builds on all branches for Clever/godoc-docker #9

Closed xavi- closed 7 years ago

xavi- commented 7 years ago

This an automated PR

Risk rating: 1 clever clover :four_leaf_clover:
or 0.1 oauth deploys :shipit:

So free to merge yourself

Details:

After much discussion, it seems worthwhile to enable docker builds on all branches. It's always been difficult to deploy development branches to dev. Which is kinda ironic. Don't you think? It's like ten thousands tests when all you need is a deploy. It's like breaking the build by merging to master. Isn't it ironic? It's a little too ironic. I really do think.

Once merged, you'll be able to run ark start Clever/godoc-docker -b <branch> on a whim. No more "temporary" changes to circle.yml. After this PR, you'll live in a world free of sudden master failures due to subtle Dockerfile changes. We'll live in a world of more dev deploys and fewer flares.

Free docker images for all!

The downside? Slower builds, but isn't freedom worth waiting for?

Jira: https://clever.atlassian.net/browse/INFRA-2257

Why was I get picked?

This is how assignees were picked:

function pickRandomAssignee(appInfo) {
    let team = appInfo.launch.team
    let shepherds = appInfo.launch.shepherds;
    if(shepherds && team != "{{.TeamName}}") {
        return shepherds[(Math.random() * shepherds.length) | 0];
    }

    if(team == "{{.TeamName}}") { team = "eng-infra"; }
    if(team) {
        let members = teams[team];
        return members[(Math.random() * members.length) | 0];
    }

    if(appInfo.repo == "cleverville") { return "stephanie.chen@clever.com"; }

    return "dunno-pick-manually";
}