Open TuukkaIkius opened 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 7:57am |
Something might be tangled in the recent PRs. they all have this same engaged code instead of only the pixel code. Could you take a look?
Yes this is on purpose. For convenience I based these tracking PRs off the Initial GTM Migrations branch as they all use the same logic for tracking their respective engaged view events. In hindsight probably a bad move but that PR will be merged before these other tracking event PRs so I don't imagine there will be issues.
Ah ok, no worries. In the future, if you open the PR against the branch that another PR is open for, when that base branch merges, all the other PRs automatically get rebased to master. Makes it easier on you!
Changes
Next PR: https://github.com/gravitational/next/pull/2479 Blog PR: https://github.com/gravitational/blog/pull/532
Merge checklist
Testing Checklist