search

gravitational / planet

Installable Kubernetes delivered in containers
Apache License 2.0
51 stars 18 forks source link

Kubernetes 1.19 support #825

Closed bernardjkim closed 3 years ago

bernardjkim commented 3 years ago

Description

This PR supersedes https://github.com/gravitational/planet/pull/811, and bumps the Kubernetes version to 1.19.8.

This PR only includes the minimum required changes to upgrade the Kubernetes service components. It does not bump Kubernetes client package versions. We will eventually want to upgrade client packages, but this will require larger changes and will be implemented in a separate batch of PRs.

wadells commented 3 years ago

This PR supersedes #811, and bumps the Kubernetes version to 1.19.8.

Can we close #811 for the time being (but keep the branch around)?

This PR only includes the minimum required changes to upgrade the Kubernetes service components. It does not bump Kubernetes client package versions. We will eventually want to upgrade client packages, but this will require larger changes and will be implemented in a separate batch of PRs.

With this merged will master/7.1 be in a unsupported/partially broken state until the rest of the migration changes land then?

I like that you're chunking up the work into manageable pieces, but I worry that we may end up in a half migrated limbo for an extended period.

bernardjkim commented 3 years ago

With this merged will master/7.1 be in a unsupported/partially broken state until the rest of the migration changes land then?

Kubernetes is backwards compatible with clients, so Kubernetes 1.19 will still work with the current client packages. However, client code will not be able to use new features added into 1.19, and some deprecated API need to be updated.

This batch of PRs is dealing with updating deprecated API. https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters

Until we upgrade client packages, Gravity may not be able to take advantage of the new features in 1.19, but Gravity should still be in a working state with these changes.

wadells commented 3 years ago

Thanks! Those docs/explanation are super helpful.