search

gravitational / planet

Installable Kubernetes delivered in containers
Apache License 2.0
51 stars 18 forks source link

bump runc to avoid CVE-2021-30465 #848

Closed knisbet closed 3 years ago

knisbet commented 3 years ago

Should we update

https://github.com/gravitational/planet/blob/f476b7375bcaf25c1f31f941cdeee6ac4714ad26/Dockerfile#L5 as well?

Uhh good question, traditionally we put all external deps in parameters (or hard coded them), not sure why DOCKER_VER exists in two places.

bernardjkim commented 3 years ago

Looks like this Dockerfile was added recently and you guys had a discussion about the issue of diverging variables https://github.com/gravitational/planet/pull/838#discussion_r633180652

knisbet commented 3 years ago

Looks like this Dockerfile was added recently and you guys had a discussion about the issue of diverging variables #838 (comment)

Yea and I immediately forgot about the discussion, so would've broken local builds by mulesoft, thanks for catching @bernardjkim