gravitational / protoc-gen-terraform

Generates Terraform provider schemas and unmarshallers from protobuf definitions
Apache License 2.0
17 stars 5 forks source link

Terraform Framework #15

Closed gzigzigzeo closed 2 years ago

gzigzigzeo commented 2 years ago

What's inside:

Please, git tag v1.0.0 after merge.

tcsc commented 2 years ago

We're replacing vendoring with modules in other places, we should probably do that here as well, unless there is a very compelling reason not to.

If we do go down that path, I would strongly suggest doing it in a separate PR and then rebasing this on top of that, which would delete -at a guess- 90% of this PR.

gzigzigzeo commented 2 years ago

We're replacing vendoring with modules in other places, we should probably do that here as well, unless there is a very compelling reason not to.

I totally agree. Done.

gzigzigzeo commented 2 years ago

@tcsc I wish it was, but I do not see a good division criteria. Would it help if we had a pair session? You definitely could cut off gen_* files, though. The only purpose of them is to generate code and the target code is well tested.

gzigzigzeo commented 2 years ago

Changed version behaviour. main.Version used to be passed via ldflags, but this would leave Version blank on go install (it does not provide any values for ldflags). So, from now on go:generate would put the current git tag to VERSION file, and file contents gets embedded into main.Version variable using go:embed.

gzigzigzeo commented 2 years ago

@Joerger I am really sorry, I must missed this out, but the branch was merged into chore/remove-vendor instead of master :-(

Joerger commented 2 years ago

@Joerger I am really sorry, I must missed this out, but the branch was merged into chore/remove-vendor instead of master :-(

No worries, I should have caught that as well. Can you reopen chore/tfsdk and base it off master?